"You never have the right to withhold knowledge."

Of course he has the right to withhold knowledge. He's a free individual, not the property of his employer.

But I agree with everything else you said - knowledge makes you more valuable to your employer, so it's usually in your best interests to share it. And if you think you can get a better deal elsewhere, by all means look for another job.