Skip to content

Comment on Primer – CSS toolkit and guidelines that power GitHubparent

Comments

The real problem here is using vertical paddings.

One solution I've found to getting vertical heights the same across browsers is to use no vertical padding, and large line-heights.

Absolutely no problem with vertical padding—this particular problem is a Chrome bug.

Fair enough, I take it back :)

That being said, I have seen lots of vertical "off-by-one" issues related to trying to combine line-height, vertical-align, and padding.

Hah, yeah, nothing to rebuttal there lol. We're forever facing problems with that kind of stuff.

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.