Skip to content

Comment on FizzBuzz: the test helps filter out the 99.5% of programming job candidatesparent

Comments

I find my version much more readable. I am a hobbyist, is there anything better in beardo's version apart from being re-usable? Mine seems more like a direct transformation of the "verbal" logic into simple code.

    <?php
    for ($i=1;$i<=100;$i++) {
      if ( ($i%3===0) AND ($i%5===0) ) {
        echo "FizzBuzz\n";
      } else if ($i%3===0) {
        echo "Fizz\n";
      } else if ($i%5===0) {
        echo "Buzz\n";
      } else {
        echo $i."\n";
      }
    }
    ?>

Three things, mine is PHP 5.6 (Generator), second, I'm only using both 'Fizz' and 'Buzz' once. Maybe you can try to rewrite your code to something similar that concatenates the two strings ;) Last, mine version does not rely on `echo`, it generates a list and uses an foreach to print it.

But why are these good things in a clearly trivial toy problem? YAGNI, premature optimisation, etc.

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.