Skip to content

Comment on Ask HN: Etiquette around altering commits in pull requests on GitHubparent

Comments

I lean towards merging as is and fixing afterwards. Or doing a manual merge locally, fix whatever needs to be fixed, and then push to master. There is just something about changing other people's commits that doesn't sit well with me. But maybe there is something about the author/committer feature of Git and how it's intended to be used that I'm not understanding.

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.