Comment on On Pull RequestsparentComments−entropy_12yYou don't need to force push at all. You could just apply the changes to your PR in a different branch(completely local, rewrite history as much as you want, etc, etc) and then submit a second PR with that.−davexunit12yA whole new PR? That just shows how broken PRs are if that's the solution to this problem.−jimktrains212yIt's _A_ solution, but not a good one. I think most people consider it OK to force-push a PR branch and update the existing pull request.−davexunit12yThere's a lot of opportunity for destruction with a force push, so it seems weird to consider it acceptable in a code review workflow.
Comments
You don't need to force push at all. You could just apply the changes to your PR in a different branch(completely local, rewrite history as much as you want, etc, etc) and then submit a second PR with that.
A whole new PR? That just shows how broken PRs are if that's the solution to this problem.
It's _A_ solution, but not a good one. I think most people consider it OK to force-push a PR branch and update the existing pull request.
There's a lot of opportunity for destruction with a force push, so it seems weird to consider it acceptable in a code review workflow.