Comment on Add heartbeat extension bounds checkComments−kzrdude12y1 + 3 + padding and 1 + 3 + 16 are repeated. I suspect the magic 16 is actually just the padding too.−nate_martin12yI'm curious as to why they are not using constants or preprocessor macros for these values. It seems weird for it to be repeated in multiple places.−wyager12yProbably just to make it easier to understand what's going on. If they just had "20+..." it wouldn't give you any hints where the 20 came from.−kzrdude12yyou'd have a define with an understandable name instead of just the magic constant 20.−mikeash12yYou could even make a constant for 1, 3, and 16 separately, then still add them together in the code. It may seem excessive for such a small case, but in my experience it really helps readability to have kWhateverFieldSize instead of 1.−whadarOP12yYeah, it just that you wanna make sure the padding variable is not being overridden by some malloc ;)
Comments
1 + 3 + padding and 1 + 3 + 16 are repeated. I suspect the magic 16 is actually just the padding too.
I'm curious as to why they are not using constants or preprocessor macros for these values. It seems weird for it to be repeated in multiple places.
Probably just to make it easier to understand what's going on. If they just had "20+..." it wouldn't give you any hints where the 20 came from.
you'd have a define with an understandable name instead of just the magic constant 20.
You could even make a constant for 1, 3, and 16 separately, then still add them together in the code. It may seem excessive for such a small case, but in my experience it really helps readability to have kWhateverFieldSize instead of 1.
Yeah, it just that you wanna make sure the padding variable is not being overridden by some malloc ;)