Comment on Hardening Perl's Hash FunctionparentComments−finnw12yWait, does that mean that iterating across the members of a Lua table is not in deterministic order?Yes. And it is documented as such. Any dependency on repeatable iteration order is a bug.−Pxtl12yHuh. I'm not involved directly in SpringRTS, but I'm going to take a look at the code... I assume there's a compilation flag for Lua to disable that, or they've hacked it up and are using a custom interpreter, because protecting sync is paramount.−avar12yJust using "sort(hash-keys())" instead of "hash-keys()" should be a trivial patch that fixes this.
Comments
Yes. And it is documented as such. Any dependency on repeatable iteration order is a bug.
Huh. I'm not involved directly in SpringRTS, but I'm going to take a look at the code... I assume there's a compilation flag for Lua to disable that, or they've hacked it up and are using a custom interpreter, because protecting sync is paramount.
Just using "sort(hash-keys())" instead of "hash-keys()" should be a trivial patch that fixes this.