Skip to content

Comment on Show HN: Encrypted end-to-end file transfer

Comments

It looks nice and I wish you luck with it. A couple of tips (or nitpicks) regarding wget-gpg:

filename=$(echo "$1" | sed 's/\// /g' | awk '{ print $4 }')

1. You could remove the sed, if you change the field separator:

  $(echo "$1" | awk 'BEGIN {FS="/"} {print $5}'
(this might be better for file names with spaces in them; though, if I understand your use case, this will never happen, but you might need to deal with space-to-%20 in wsend-gpg and then %20-to-space in wget-gpg...)

2. Or you could just replace this with:

  filename=$(basename "$1")

> filenamed=$(echo "$filename" | sed 's/.gpg//')

3. The problem that this cuts the first occurrence of .gpg in the file name, so nitpick.gpg.nitpick.gpg will become nitpick.nitpick.gpg instead of nitpick.gpg.nitpick

To remove this substring from the end of the string, you can probably replace the pattern with a greedy one or just use:

  filenamed=${filename%.gpg}
EDIT: previous related discussions:

https://news.ycombinator.com/item?id=6083884

https://news.ycombinator.com/item?id=6158719

https://news.ycombinator.com/item?id=6179424

I like your persistence and glad you finally made it to the front page. Good luck.

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.