Comment on Show HN: Mixpanel Event Queueing WrapperComments−skotzkoOP13yThis is my first open-source project. I was frustrated that Mixpanel did not natively include a queueing system for events (a la Google Analytics, KISSmetrics, etc) so I built one. Hope others find it useful and welcome any feedback.−Robin_Message13yYou should probably use the magic arguments array in your function to avoid the ugly array you are using as the second argument. _meq.push("track",["event_name",{property_name: "value"}]) becomes _meq.push("track","event_name",{property_name: "value"}) By changing the top of the mixpanel function to: mixpanel: function() { var mixPanelArgs = Array.prototype.slice.call( arguments ); var functionName = mixPanelArgs.shift();−skotzkoOP13yAh, great point. Missed that. Updated and going to push update shortly. Thank you.[EDIT] Pushed. Great catch, thanks again.
Comments
This is my first open-source project. I was frustrated that Mixpanel did not natively include a queueing system for events (a la Google Analytics, KISSmetrics, etc) so I built one. Hope others find it useful and welcome any feedback.
You should probably use the magic arguments array in your function to avoid the ugly array you are using as the second argument.
becomes By changing the top of the mixpanel function to:Ah, great point. Missed that. Updated and going to push update shortly. Thank you.
[EDIT] Pushed. Great catch, thanks again.