Skip to content

Comment on Show HN: Hacky – Hacker News app for Mac

Comments

Nice app. Just a few UI and code comments.

The titlebar is too big in my opinion. I'm writing an app with a thicker than usual titlebar and had a look around a number of apps before deciding on the exact height. I found the best height to be 36px. This allows for nicely a nicely spaced title and traffic lights, but isn't too large. Clear for Mac goes for a titlebar a bit bigger than this, but Hacky is far larger.

The bottom bar seems like it's only there to place the "Mark all as read" button. Could this button be instead placed on the titlebar? If not, I think it's the wrong type of button to use in this context. I believe the correct button style is "Round Textured" as listed in Interface Builder.

Despite these two comments, I actually really like the user interface. It looks good and is generally well thought out.

A few comments on the project, it might be worth using CocoaPods. This is entirely up to you, but I know for a fact that INAppStoreWindow and AFNetworking are in the database, and it might make handling dependency updates easier. Not using CocoaPods isn't necessarily a bad thing at all though.

Having had a quick look at the code, and having compiled it, there are a lot of compiler warnings! A few can be fixed just be configuring the project correctly, adding frameworks that AFNetworking wants for additional functionality, etc, but a few issues surrounding your mixed use of instance variables and properties that will generate their own.

There is also an issue with declaring a method as taking NSUInteger pointers, and yet using it for normal NSUIntegers, and then assigning to NSUInteger properties. It works, but it's an easy fix and pointer issues can be annoying to debug later on if they start to cause errors.

Awesome feedback! It's noted and will be investigated as soon as I have time ;)

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.