The important part is the quality of the code, how well-considered its design is, how well it gels with existing code, how readable it is to other humans, how well documented it is, how well its author understands it (and thus, can make surgical changes if needed), and how well it was tested.
A PR that implements a sought out feature or bug fix can be practically worthless if it doesn’t check some percentage of those boxes. The line differs per project naturally, but almost nobody wants a PR that is missing all of them.
Comments
The important part is the quality of the code, how well-considered its design is, how well it gels with existing code, how readable it is to other humans, how well documented it is, how well its author understands it (and thus, can make surgical changes if needed), and how well it was tested.
A PR that implements a sought out feature or bug fix can be practically worthless if it doesn’t check some percentage of those boxes. The line differs per project naturally, but almost nobody wants a PR that is missing all of them.