Skip to content

Comment on Discussion of the Benefits and Drawbacks of the Git Pre-Commit Hookparent

Comments

if you're not running the test-suite on pre-push your tests are slow

Of course tests are slow. If they're fast they're skipping something. You probably want to be skipping something most of the time, because most of the time your change shouldn't cause any side-effects in the system, but you definitely want a thorough test suite to run occasionally. Maybe before merge, maybe before release, maybe on some other schedule.

Each individual change might be fine in isolation but cause excessive memory pressure when accumulated with other changes, for example. Unit tests won't catch everything, integration & functional (hardware in-the-loop) tests are needed. I even sometimes have to run tests in a thermal chamber repeatedly to cover the whole -40-105°C temperature range, since the firmware I work on runs on hardware that allows that range & performance varies with temperature.

but you definitely want a thorough test suite to run occasionally.

that's what ci is for

anyway, if you're doing embedded development and can distinguish between different kinds of testing then my previous post is not meant for you

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.