Skip to content

Comment on Discussion of the Benefits and Drawbacks of the Git Pre-Commit Hookparent

Comments

Couldn't disagree more.

Waiting for a CI step to tell me something's wrong when I could've found out locally is a waste of time.

Sure, I can hand-run checks locally, but having a way of doing it "automatically" pre-push gives me consistency and saves time.

That's fine, but it shouldn't be enforced on all contributors. What matters is that failures don't get merged, not that they don't get committed.

Yeah.

As long as "don't get merged" includes squashing so that whatever your (non)hooks didn't catch locally don't end up causing failures for rebases/merge conflict resolutions for others (assuming there are repo-level hooks people are expected to be using).

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.