Laravel has taught me many things about maintainability, but it's mostly "don't write code like Laravel". My favorite is how cache tagging was broken in Laravel, and there was a complete PR presented to fix it, but Taylor just summarily closed the PR and removed all mention of cache tagging from the documentation instead.
Looking at the PR you posted below, your comment seems to be slight misrepresentation:
taylorotwell commented on Sep 13, 2023
> I personally don't have the knowledge to trust merging this sadly. I would
> prefer to either de-document cache tags or recommend their use with Memcached
> only. Cache tags and Redis have been a maintenance and complexity nightmare.
Thanks for those - turns out, I'm just lucky and have been using in a manner this never reared its head in my (only one) application where they're used. Heavily. But with the way things are done - the tagged caches were only flushed during a time that there were never going to be new keys added.
Comments
Laravel has taught me many things about maintainability, but it's mostly "don't write code like Laravel". My favorite is how cache tagging was broken in Laravel, and there was a complete PR presented to fix it, but Taylor just summarily closed the PR and removed all mention of cache tagging from the documentation instead.
Looking at the PR you posted below, your comment seems to be slight misrepresentation:
https://github.com/laravel/framework/pull/48078#issuecomment...
I must admit, migrating a 500,000 line codebase from V5 to V10 was an extremely difficult and lengthy process.
What was/is broken? I've been using cache tagging for years and haven't seen any issues.
Apparently a severe memory leak: https://old.reddit.com/r/laravel/comments/16yr8rb/why_were_c...
The PR in question: https://github.com/laravel/framework/pull/48078
Thanks for those - turns out, I'm just lucky and have been using in a manner this never reared its head in my (only one) application where they're used. Heavily. But with the way things are done - the tagged caches were only flushed during a time that there were never going to be new keys added.