Skip to content

Comment on This Pull Request was generated automatically using cover-agent

Comments

Those are some pointless tests.

E.g. test_activation_stats_functions [1] that just checks that the returned value is a float, and that it can take random numbers as input.

test_get_state_dict_custom_unwrap [2] is probably supposed to check that custom_unwrap is invoked, but since it doesn't either record being called, or transform its input, the assertions can't actually check that it was called.

[1] https://github.com/huggingface/pytorch-image-models/pull/233...

[2] https://github.com/huggingface/pytorch-image-models/pull/233...

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.