1. Can I understand it - this is a low bar as I don't do much coding anymore and often the teams I'm working with use different languages / tooling to what I'm familiar with. Try to avoid anything too clever!
2. I try to think of stuff other than the base functionality, often non functional requirements e.g. storage of system config and secrets and where, performance, security, error codes, naming, modularisation. A lot of my thinking comes from reading code complete when I 1st started coding.
3. Not really part of code review but I try and get an idea of whether the developer understands the reason for their code in the wider context of the project.
Comments
1. Can I understand it - this is a low bar as I don't do much coding anymore and often the teams I'm working with use different languages / tooling to what I'm familiar with. Try to avoid anything too clever!
2. I try to think of stuff other than the base functionality, often non functional requirements e.g. storage of system config and secrets and where, performance, security, error codes, naming, modularisation. A lot of my thinking comes from reading code complete when I 1st started coding.
3. Not really part of code review but I try and get an idea of whether the developer understands the reason for their code in the wider context of the project.