Comment on Security vulnerability in MySQL ubuntuparentComments−mjschultzOP14yHere is the fixed version of the MySQL code: https://bazaar.launchpad.net/~mysql/mysql-server/5.1/view/35... (line 534 didn't have the test()) previously)−willvarfar14yyeap, strange; I'd have thought the obvious natural code would have been: return 0 == memcmp(hash_stage2, hash_stage2_reassured, SHA1_HASH_SIZE) As in, return a bool on whether it matched.I mean, as I read it, the function returns true if they don't match?
Comments
Here is the fixed version of the MySQL code: https://bazaar.launchpad.net/~mysql/mysql-server/5.1/view/35... (line 534 didn't have the test()) previously)
yeap, strange; I'd have thought the obvious natural code would have been:
As in, return a bool on whether it matched.I mean, as I read it, the function returns true if they don't match?