jacobolus on Super Simple Mocking For Python

Comment on Super Simple Mocking For Python

   self.mocks = dict(zip(args[::2], args[1::2]))

Makes for a very unpythonic feeling API. I’d be interested to hear why the author settled on this design, and see example uses that he likes the look of. Are there any other libraries which use this pattern?

tebekaOP14y

You can either use mock(obj, {'x': 1, 'y': 2}) or mock(obj, 'x', 1, 'y', 2). I thought it'll be nice to provide both options, but you might be right and using just a dict of mocks is more Pythonic.

MBlume 14y

At risk of bikeshedding, I think the "most pythonic" approach would be mock(obj, x=1, y=2)

Seriously though, cool lib, thanks for it =)

jacobolus 14y

Yes, the most pythonic is:

  mock(obj, x=1, y=2)

Which you get by:

  def __init__(self, obj, **mocks):
      self.obj = obj
      self.mocks = mocks

This can then also be called (using the built-in double-star-unpacking feature) as:

  mock(obj, **{'x': 1, 'y': 2})

or even

  mock(obj, **dict([('x', 1), ('y', 2)]))

Then there’s no explicit need to support multiple alternative function signatures, and in particular you don’t get people using the (quite atypical and therefore semantically ambiguous):

  mock(obj, 'x', 1, 'y', 2).

tebekaOP14y

Thanks, updated the code to use keyword arguments only.

Comments