tait on Show HN: Typograms, Markdown-like renderer for ASCII diagrams

Comment on Show HN: Typograms, Markdown-like renderer for ASCII diagrams

In the section on Line Ends, https://code.sgo.to/typograms/ shows a box surrounded by arrows and a dot surrounded by arrows.

The arrows that point down (down and left, down, and down and right) are rendering the arrow heads as ascii V's.

That seems different than elsewhere on the page.

    \ | /
 \   vvv   /           \ | /
  v+-----+v             vvv
 ->|     |<-           ->*<-
  ^+-----+^             ^^^
 /   ^^^   \           / | \
    / | \

tait 4y

Hi! This is interesting and I plan to use it for work. Today.

In answer to my above inquiry:

It looks to me like this section causes consecutive 'v's to be interpreted as text; it might be nice to carve out v's or give alternative glyphs for down arrows or something:

  if (char.match(/[A-Za-z0-9]/)) {
          const [, right, , left] = neighbors;
          str = str || (left.match(/[A-Za-z0-9]/) || right.match(/[A-Za-z0-9]/));
        }

Also, if you have two arrows coming together diagonally, like:

  \ /
   v

The arrowhead points to the left rather than straight down. I think straight down would be preferred and not particularly difficult to code.

I would be happy to take further conversation/contributions to whatever forum you prefer - what is the best approach?

sgotoOP4y

That looks like a bug, thanks for finding it!

You are welcome to send PRs if you have the inclination!

https://github.com/samuelgoto/typograms

sgotoOP4y

Ok, submitted a quick fix here:

https://github.com/samuelgoto/typograms/commit/40829f6db1a21...

Comments