As a reviewer, this is how I approach it. And it has been catching on my team.
- Don't block the commit. Review as soon as possible.
- Focus on finding bugs.
- Ask questions if you don't understand something.
- Sometimes I make suggestions.
- Before requesting a change I ask myself. "Is it wrong or is it just not the way I would do it".
As a committer. I try to make small commits. They are easier to review.
But it only takes one person to ball up the whole process. Worse if they're some self-important early hire, promoted above their skills and full of idealism. Nobody will tell them to stfu. The tools enable them, since the process won't proceed until they hit a magic button.
I've suffered under this special kind of gatekeeping autocrat. My son has on several occasions. We've both left jobs in part because of it.
Comments
As a reviewer, this is how I approach it. And it has been catching on my team.
As a committer. I try to make small commits. They are easier to review.I agree, a good set of rules is helpful.
But it only takes one person to ball up the whole process. Worse if they're some self-important early hire, promoted above their skills and full of idealism. Nobody will tell them to stfu. The tools enable them, since the process won't proceed until they hit a magic button.
I've suffered under this special kind of gatekeeping autocrat. My son has on several occasions. We've both left jobs in part because of it.