Agreed. Before instituting mandatory code reviews, nobody asked if people need to be trained in code reviewing.
Nitpickers are the worst. Before someone replies with "use linters" and other such obvious things, I'd like to ensure that nitpicking often goes beyond automation. Nitpicking is imposing preferences over others. If a language or infra supports something, nitpicking one vs another is often futile in the scheme of things.
I would strongly encourage code reviewers to self reflect and see how many PRs reviewed by them actually end up in production within a day. If you don't have many, you are the problem.
Comments
Agreed. Before instituting mandatory code reviews, nobody asked if people need to be trained in code reviewing.
Nitpickers are the worst. Before someone replies with "use linters" and other such obvious things, I'd like to ensure that nitpicking often goes beyond automation. Nitpicking is imposing preferences over others. If a language or infra supports something, nitpicking one vs another is often futile in the scheme of things.
I would strongly encourage code reviewers to self reflect and see how many PRs reviewed by them actually end up in production within a day. If you don't have many, you are the problem.