Comment on Neural search library in Python for medium-sized corporaComments−fermigier4yInteresting.1) Why do you need both lunr and elasticsearch as dependencies?2) You shouldn't pin the exact versions of your dependencies in setup.py. Otherwise it makes it very hard to integrate.−raphaeltyOP4yHi,1) The dependency on the Elasticsearch python client allows Elasticsearch to be used as a retriever. The same goes for Lunr. It might be interesting to separate the different dependencies.2) Of course I'll update it.
Comments
Interesting.
1) Why do you need both lunr and elasticsearch as dependencies?
2) You shouldn't pin the exact versions of your dependencies in setup.py. Otherwise it makes it very hard to integrate.
Hi,
1) The dependency on the Elasticsearch python client allows Elasticsearch to be used as a retriever. The same goes for Lunr. It might be interesting to separate the different dependencies.
2) Of course I'll update it.