Skip to content

Comment on Things Everyone Should Do: Code Reviewparent

Comments

It's more like without a code review you can only commit to your personal scratch space.

A more accurate way to state "At Google, no code, for any product, for any project, gets checked in until it gets a positive review" would be that "No code goes into production without a positive code review."

Which is completely reasonable. The original contention of no checkins at all sounds like hell.

The original statement makes sense if they are not using a DVCS (I know that at least a couple years ago they were mostly a Perforce shop). If they are now using a DVCS then they probably have repos for different code stages plus all the local repos.

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.