Comment on Kite Responds to the Minimap and Autocomplete IssuesparentComments−thisacctforreal9yto be fair with that specific example, they changed from a purpose-built function, to a shell call including (albeit extremely simple) text parsing.I'd generally prefer not to have the git(1) incantation hanging around in an unrelated function.−conradk9yThe dependency "git-rev" uses a shell-call too, so this PR doesn't change much apart from removing the dependency itself.Here's the original code from the "git-rev" package: https://github.com/tblobaum/git-rev/blob/master/index.js
Comments
to be fair with that specific example, they changed from a purpose-built function, to a shell call including (albeit extremely simple) text parsing.
I'd generally prefer not to have the git(1) incantation hanging around in an unrelated function.
The dependency "git-rev" uses a shell-call too, so this PR doesn't change much apart from removing the dependency itself.
Here's the original code from the "git-rev" package: https://github.com/tblobaum/git-rev/blob/master/index.js