I'm skeptical `documentAndPdfSavedOnDiskJsonStates` is a useful variable name. Without context it's hard to say. It sounds like you have a couple of collections of states (state names?) for various document types.
PDFs are already documents, so that seems redundant. It already sounds like `savedDocumentStates` and `thumbnailStates` would be adequate--but again, without any context, it's impossible to know if that would be adequate.
(Personally I'd have a type => state mapping and skip them altogether, and use a different form of classification altogether.)
There is a domain specific case indeed, would've been better perhaps to offer a bit of context: https://speakerdeck.com/amorroxic/reactive-resumes - we deal with different types of documents then pdf conversion as standard in, followed by parsing, ai, analysis.
Comments
It depends.
I'm skeptical `documentAndPdfSavedOnDiskJsonStates` is a useful variable name. Without context it's hard to say. It sounds like you have a couple of collections of states (state names?) for various document types.
PDFs are already documents, so that seems redundant. It already sounds like `savedDocumentStates` and `thumbnailStates` would be adequate--but again, without any context, it's impossible to know if that would be adequate.
(Personally I'd have a type => state mapping and skip them altogether, and use a different form of classification altogether.)
There is a domain specific case indeed, would've been better perhaps to offer a bit of context: https://speakerdeck.com/amorroxic/reactive-resumes - we deal with different types of documents then pdf conversion as standard in, followed by parsing, ai, analysis.