Skip to content

Comment on Show HN: Searchkit – React components for elasticsearch

Comments

I'm enthused, but would suggest you don't put an entry in the user's history for every keystroke in the search box.

Yes, this! People seem not to know when to use replaceState over pushState. And in my eyes this is a clear candidate for replaceState. (There are also examples the other way around, such as GitHub's PR tabs, drives me insane every time.)

Yes! Thanks for noticing a side effect of the way we update our url. It should be replaceState for the search box. Other actions like pagination, applying filters and sorting should be pushState however.

We also throttle the searchbox search requests as you type.

fixed now :), try the demo now http://searchkit.co

thanks, will fix this today :D

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.