Skip to content

Code of Conduct: Open Source

mahdiyusuf.com
15 pointsomarshammas4 comments
On HN

Comments

I have written a lot of code for OS that doesn't get committed into master.

I was wondering what I could do to improve my code written to code committed ratio.

Still open to suggestions.

Write highly detailed commit messages.

Email the owner to discuss what you're adding and why, especially if it's a big thing.

Keep your commits small--nothing worse than a mega-commit which fixes 3 different bugs and updates the formatting for 10 files.

Make sure to follow the project's formatting and naming conventions.

Also make sure you update and add relevant tests and documentation.

The pull request referenced in the post can be seen here: https://github.com/twitter/bootstrap/pull/6127

AboutSource Built by g1lg1l

Hackerly is an independent reader for Hacker News, built on the public HN API. Not affiliated with Y Combinator.